Feature proposal: Editing of posts

(goob) #61

@mcv, the lack of progress in certain areas is purely a matter of (a lack of) resources. Google has billions of dollars and thousands of paid developers to throw at software; since the project was handed to its community in 2012, diaspora* has been built and maintained purely by volunteers working in their spare time. The core of developers who have continued working on diaspora* over a period of years – rather than making a few PRs and then disappearing, perhaps with a feature half-developed and abandoned – has remained small. This has, sadly, meant that some much-needed features have not been developed.

The foremost thing that is needed is for someone who wants a feature and who has the necessary skills to step forward and say ‘I’ll make this’, and then go ahead and work on it until completion. If you’d like to be one of those people, that would be fantastic. You can be assured of as much support as the core team is able to give you; although, given the voluntary nature of all work on diaspora*, it can sometimes take a long time to properly review a complex PR.

I hope you’ll want to join the team!

(Martijn Vos) #62

I’m not talking about comparing Diaspora to Google. Google has its own issues. I’m just concerned about the health of the project, and the community’s ability to maintain and develop this project.

Well, I decided to dig through the code for this to see if I can fix this. I’m planning to follow the example of deleting a post, since that is in many ways similar (needing to send updates on existing content). But it’s also a test to see how maintainable this code is. If this is going to be a painful journey full of headaches, it’s unlikely I’m going to spend a lot of energy on Diaspora.

I suppose I could use someone to point me to the right bits of code. The javascript keeps talking about this.model.destroy which I can’t find anywhere (is it from some library?). A quick rundown of how updates are sent to and received from other pods would probably be helpful too.

(Flaburgan) #63

Maybe an intermediary step could be like on comment? This would require to dig to the entire stack from federation to front-end, so you will become familiar to everything, but without the need of discussions and choices: the UX is pretty simple.

Like for edition, the federation part is already done, and the back-end also already have some code. Here is the github issue if you are interested.

Also, be aware that diaspora* will very soon have a docker image to set up the dev environment, which saves a few hours.

(Martijn Vos) #64

Could be. On the other hand, based on that discussion on github, likes apparently have a massive impact on the database, and maybe a different DB solution is required. It might not be that easy after all.

(Hank G) #65

Yeah getting the likes on comments working again would be awesome. The writings I’ve been seeing is that we think the performance problem from before has been resolved. What I can’t recall or may have missed is if anyone ran scaling tests to prove it or if the redesign makes its resolution patently obvious.

(goob) #66

Likes had a massive impact on the database until they were removed, but that was several years ago and much in the core code has changed since then. It’s therefore possible that likes as currently implemented wouldn’t have the same impact. Let’s ask @supertux88, @jhass and @denschub (who know the code the best) what thoughts they have about the current situation regarding likes on comments.

(Hank G) #67

I didn’t realize @flaburgan had sketched out what has to be done to get the likes off the ground again in terms of confirming the performance behavior has been fixed… https://github.com/diaspora/diaspora/issues/2999#issuecomment-375084489

(Gonzalo) #68

YES, editing a post should be allowed. I have read the arguments against (to avoid leaving comments done to a previous text or post, that later was changed). But his is simple to be solved: Diaspora could automatically include a comment below like many fora and other discussion sites do: "edited …(date)…, …(hour)… and “voilá!”.

(goob) #69

Please, people, don’t add to this or other discussions just to say “You must do this.”

@Gonzalo_VC, if you read this discussion you’d see that the decision to implement editing of posts was taken a long time ago. The arguments against were in a far earlier stage of discussion.

Once that decision was taken, a lot of work was then needed to make it happen. One of diaspora*s core team implemented support for post editing in the federation code, so it is now possible to build the feature. What is needed is for one or more members of diaspora*'s community to decide that this feature is important enough to them to create it.

It is simple to describe in a few words what a feature should do, but to actually implement this in code in a workable and reliable way – NOT simple! There’s a lot more to it than ‘voilà!’

(Rik44444) #70

Dear all, thank you for working on this. I really appreciate it; this would be a great function. Just to add my views of how this should work: i really like the edit function on Linkedin: you are able to edit it (the button in Diaspora could be just besides the delete/garbage button) and after you have edited the message, a small tiny message appears below the message saying that it has been edited.
hope that helps,

(Dennis Schubert) #71

I am locking this post for now, as people apparently are unwilling to read. If you plan on working on this, and have some questions that you deem fit for this thread, please reach out to any team member, either here on Discourse via a private message, or on IRC. We will happily unlock this thread in that case.

There are 70 replies worth of disucssions and decisions on how this feature should look like, how it should feel like, and what the technical implementation needs to be. So far, noone has completed that work, and that’s the state of the issue. There is no need for further comments here, besides future discussions on technical issues.