Refactoring the Single Post View

I just wanted to say that we should keep stuff that affects other parts of the app out of our heads for now, like the special casing when linking from the notification or getting back to the stream on point where you left is way out of topic here. And mocks should reflect that, they should work with leaving the rest of the app untouched. I consider stuff that needs to touch the other, working parts as a feature.

Okay guys it’s time to take a decision !

Hm, maybe we can do a public approval voting on all mockups?

Sounds good to me, how do you want to do this? We have several really good working mockups from @flaburgan, how should we go forth with determining which designs we ultimately want the most?

Perhaps they could each be given a letter A, B, C and so on, and we could either post here which one we like the most, or rank our favourite three in order.

@goob that’s not how approval voting works: http://en.wikipedia.org/wiki/Approval_voting

Jonne, I don’t understand your comment. Sean asked how best to do this (to select which was the favoured draft single-post view); I suggested two possible methods of doing this. Neither of my suggestions are intended to be your ‘approval voting’.

I think we simply should vote about the blocking points : add possibility to hide comments, two scrolls or one… and at the end, we will be able to make it.

Is there any reason why the original single-post view can’t be restored? Is it incompatible with the current code-base? It might be simpler than creating a new one.

Or, even better, the two (or more) SPV designs could be presented as user options, so people can select which one they prefer using.

the code base would be more complex with an option system. But I agree we should look at this previous SPV first. I’ll try to look at the pistos code.

Pinging this discussion again. I’ve had some more spare time open up, and I wouldn’t be against taking another stab at this. Our currently SPV is less-than-stellar, and I worry that it might possibly even hurt adoption from future users.

I guess my primary question as a starting point is, how do we render the SPV using stream elements, as was suggested in the past?

We can split this up into several things that need to happen:

  1. Decide once and for all on a reference design mockup to work from. We have some really good ideas, they just need to be streamlined and then polished.

  2. Fix the visuals of the SPV to make use of this new design, possibly being built out of stream elements.

  3. Purge as much of the old SPV-related stuff as possible. Kill it with fire. That means post-viewer templates, some Backbone code, etc.

I should have more time in May to work on that, did not do anything in April, sorry…

Btw, after some big discussion with users, it seems that the “simple” revert of the spv should be considered as an option too.

“simple” indeed. Can’t have enough quotes around that. On a coding level my effort estimation doesn’t change, no matter if we go a step backward or forward. I’m thinking you get that feedback because that’s what people know, the last change made it worse, so they’re not trusting a new approach.

Could we have a vote on the most popular designs that have been talked about here? Basically Loomio supports 4 options in a vote… Anyone want to collect the designs?

Please lets drop the “rollback to before current SPV” - that is going backwards - we need to think forward :slight_smile:

Please lets drop the “rollback to before current SPV” - that is going backwards - we need to think forward :slight_smile:

We need to do something integrated in the diaspora website, the current spv is something apart, and simply add a header will not solve this problem. We have to go forward, sure, but by keeping an uniformity to the website.

Is it worth posting a notice using the Diaspora HQ account asking for people willing to work on this? It’s a major issue and there’s general agreement about what to do - it’s just the fine-tuning of how the design should be and how it should function.

If this would be useful, what should the notice say?

If we can have a vote on four of the mock-ups using the schema Jason outlined below (‘Yes’ to vote for option 1, ‘Abstain’ to vote for option 2, ‘No’ to vote for option 3, ‘Block’ to vote for option 4) and make a decision, we can then ask anyone who’s keen to help to get stuck in on creating the code for it.

Proposal: Design for single post view

Got to start voting down on design somewhere, so here we go. As we haven’t had any new mock-ups recently and to be honest any of the designs would be awesome. Of course our awesome coders will make them easier to modify than the current SVP :slight_smile:

So, here are the contestants. Vote by choosing the correct option. NOTE! Discussion is still allowed and encouraged - we can change the options and reset the timer if needed… And we are voting on a general design - small details like animations etc can be set later.

  1. YES - http://wiki.diaspora-project.org/images/c/c8/Mockup-Singlepostview.png / http://wiki.diaspora-project.org/wiki/Refactor:_Single_Post_View#Alternate_Proposal

  2. NO - http://wiki.diaspora-project.org/images/a/ad/Mockup-Singlepostview-hewiak-Combo1.png / http://wiki.diaspora-project.org/wiki/Refactor:_Single_Post_View#More_mockups

  3. BLOCK - http://wiki.diaspora-project.org/images/4/45/Spv_mock_mrzyx_big_image.png / http://wiki.diaspora-project.org/wiki/Refactor:_Single_Post_View#More_mockups (second image)

  4. ABSTAIN - http://wiki.diaspora-project.org/images/e/eb/Spv-sean-jonne.png / http://wiki.diaspora-project.org/wiki/Refactor:_Single_Post_View#Reconcilation_of_Designs


Outcome: N/A

Votes:

  • Yes: 1
  • Abstain: 14
  • No: 1
  • Block: 0

Note: This proposal was imported from Loomio. Vote details, some comments and metadata were not imported. Click here to view the proposal with all details on Loomio.

These mockups are absolutly not up-to-date, we already chose the #4 (without really voting for it) and we have now to choose about where we place the scrolls.

Please see my posts below
Mixed
Comments on the left, double scrolls
Comments on the left, unique scroll
Comments at the bottom

There are for each proposition 3 use cases (big text, short text, pictures) and you can already play with it, it’s HTML.

well, since we’ve unofficially chosen #4, let’s choose it officially now… :wink:

If you’re voting for #4, @hewiak , that’s an ‘abstain’ - see the criteria in the proposal.